MESSAGE
| DATE | 2020-12-09 |
| FROM | Lucy Phipps
|
| SUBJECT | Subject: [Hangout - NYLXS] [png-mng-implement] [PATCH] pngcheck: check 4th
|
From hangout-bounces-at-nylxs.com Wed Dec 9 11:11:00 2020
Return-Path:
X-Original-To: archive-at-mrbrklyn.com
Delivered-To: archive-at-mrbrklyn.com
Received: from www2.mrbrklyn.com (www2.mrbrklyn.com [96.57.23.82])
by mrbrklyn.com (Postfix) with ESMTP id 5BD62163FB0;
Wed, 9 Dec 2020 11:11:00 -0500 (EST)
X-Original-To: hangout-at-www2.mrbrklyn.com
Delivered-To: hangout-at-www2.mrbrklyn.com
Received: by mrbrklyn.com (Postfix, from userid 1000)
id 4E9D4163FB0; Wed, 9 Dec 2020 11:10:51 -0500 (EST)
Resent-From: Ruben Safir
Resent-Date: Wed, 9 Dec 2020 11:10:51 -0500
Resent-Message-ID: <20201209161051.GC23591-at-www2.mrbrklyn.com>
Resent-To: hangout-at-mrbrklyn.com
X-Original-To: ruben-at-mrbrklyn.com
Delivered-To: ruben-at-mrbrklyn.com
Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7])
by mrbrklyn.com (Postfix) with ESMTP id 5EC0E163F5D
for ; Wed, 9 Dec 2020 02:05:05 -0500 (EST)
Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com)
by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1)
(envelope-from )
id 1kmtWd-0001P1-8H; Wed, 09 Dec 2020 07:04:35 +0000
Received: from [172.30.20.202] (helo=mx.sourceforge.net)
by sfs-ml-2.v29.lw.sourceforge.com with esmtps
(TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1)
(envelope-from ) id 1kmtWb-0001Ou-OR
for png-mng-implement-at-lists.sourceforge.net; Wed, 09 Dec 2020 07:04:33 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Type:To:Subject:Message-ID:Date:From:
MIME-Version:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=msl2bqzz5CPVo2ZssVc5vu3bxSxVkyghf/UTQGUGoII=; b=ZT9OqIjy9nyqwoRjh6iS3K0ko8
r3lJ+JCvfRxxPVL7NtpVeZm4BTCvu5pfBP8oa9sPkyPTuQZaLAbuUzXKZl2ce+6ENHEWRTusY02RL
sQlpSC5x7FxC9IBM5g4ap9qizQ5SajGbrzxf2zPjrZEZ7TyOcAcj97vCBPQYlbYPmBsQ=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Type:To:Subject:Message-ID:Date:From:MIME-Version:Sender:Reply-To
:Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:
References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:
List-Owner:List-Archive; bh=msl2bqzz5CPVo2ZssVc5vu3bxSxVkyghf/UTQGUGoII=; b=R
+kXAuA1F6mTFweJE6YE63K6q8ULOR1b2DXZanzlmzmu4OHhInaIcVpIj4s+tBy1xz+KqWTpKwVTnJ
sK6yAzAMAlL0MurUjgNhkvfCwRtZDbnzQlnDxrBT0h8OIOPpu1HLi7YF8mORBLYoSckMX20K10x6M
P2NMiyGp3KVCR+OE=;
Received: from mail-yb1-f193.google.com ([209.85.219.193])
by sfi-mx-3.v28.lw.sourceforge.com with esmtps
(TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2)
id 1kmtWZ-007SFt-MT
for png-mng-implement-at-lists.sourceforge.net; Wed, 09 Dec 2020 07:04:33 +0000
Received: by mail-yb1-f193.google.com with SMTP id g15so401050ybq.6
for ;
Tue, 08 Dec 2020 23:04:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:from:date:message-id:subject:to;
bh=msl2bqzz5CPVo2ZssVc5vu3bxSxVkyghf/UTQGUGoII=;
b=Rny5/GLOUSLk+/YkacDsct9xHdlztGJ8nGmGQniHfR0hm5xqVBekDe/blc9J2KKB/8
v66zo/pOXy0skTHgs6vIiCdYQfrhLEIvcGXsK3yQUTbzp79XLrH/Gb6VZRjPuZW95yd7
Jb8I7ITs5T0kynpPF2CnlH4DVt7Bm+IB2dScjqPsFJz0yhwQ08TlQSnPAnwaaf5CTj/o
Gy6hVu64IJ9THxP+dQcaQqq9WF5TRS8LKSUNuKHFr1/ZlAdng2D1Kr7apTi711q0eO8h
p0OWo4JA+9Rj+8CnUQwq53S/+j6BwAevPk6uEZUJs0jvHj9yPSjjwsadYf6qMleYkvgm
TANQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
bh=msl2bqzz5CPVo2ZssVc5vu3bxSxVkyghf/UTQGUGoII=;
b=jwOhPN0389W3ax65+A36a113o2tWJyS23lezG+fi9lXE0Y0ccoxVIYq5nrdCSBrYBN
HUpMk0M6ORfw5QZJf3RxtZdMH8PYfHMJXsq9GFlZprVEzy85BchXR0htf9az3wYCxzYY
kIUg7U3Ne30EVZgDZCHNFPcDABWbpHRGmT35pVisiPQjGcqNmnk/TcLZCpFWDlupC5ny
rR57AkZtFTktuD3YUt+PYlWDAcfNVM6bmv8fItW9Lifi8+34rIpqfW40KpsE/5oNu9Z7
kIef9QRBZgOcPMD0lU1jMcwGS4IIpSKQmuWULFgrAEMModM31HZ8AO43FtECx8UO+WMA
rY8w==
X-Gm-Message-State: AOAM531xOeQkzzbCB4mDd8vbF+NczFCjWdhpvIJxuTTI0ZRxN8jSFjGg
76Vlk0bxHztypOCOdybx9mdnvjTzIM/xFwju8zWJ1/qx
X-Google-Smtp-Source: ABdhPJzSzLVhRwl80nKFCnbVg2rAYPTXqvR4XnC5fphEwfRcoHEuCGRwpbkqevITw9a6RTuBZ0zseas8vZ6Wr1EpWvM=
X-Received: by 2002:a25:6604:: with SMTP id a4mr1725056ybc.412.1607497458609;
Tue, 08 Dec 2020 23:04:18 -0800 (PST)
MIME-Version: 1.0
From: Lucy Phipps
Date: Wed, 9 Dec 2020 07:04:12 +0000
Message-ID:
To: png-mng-implement-at-lists.sourceforge.net
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(landfillbaby69[at]gmail.com)
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no
trust [209.85.219.193 listed in list.dnswl.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in
digit (landfillbaby69[at]gmail.com)
1.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.193 listed in wl.mailspike.net]
X-Headers-End: 1kmtWZ-007SFt-MT
X-BeenThere: png-mng-implement-at-lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
Content-Type: multipart/mixed; boundary="===============5421372819667012295=="
Subject: [Hangout - NYLXS] [png-mng-implement] [PATCH] pngcheck: check 4th
byte of header
X-BeenThere: hangout-at-nylxs.com
List-Id: NYLXS Tech Talk and Politics
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Reply-To: PNG/MNG implementation discussion list
Errors-To: hangout-bounces-at-nylxs.com
Sender: "Hangout"
--===============5421372819667012295==
Content-Type: multipart/alternative; boundary="000000000000ff70e805b602aa0b"
--000000000000ff70e805b602aa0b
Content-Type: text/plain; charset="UTF-8"
Turns out this doesn't report an error on PNGSuite xs4n0g01 (signature byte
4 lowercase), and I traced the problem to here a single comparison in
check_magic.
I originally submitted this to https://github.com/jbowler/pngcheck/pull/2
on the 30th of June 2019, and am finally submitting it upstream now, after
noticing the 2.4.0 release
---
pngcheck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pngcheck.c b/pngcheck.c
index 2574ffe..486bacf 100644
--- a/pngcheck.c
+++ b/pngcheck.c
-at--at- -4868,7 +4868,7 -at--at- int check_magic(uch *magic, char *fname, int which)
const uch *good_magic = (which == 0)? good_PNG_magic :
((which == 1)? good_MNG_magic : good_JNG_magic);
- for (i = 1; i < 3; ++i)
+ for (i = 1; i <= 3; ++i)
{
if (magic[i] != good_magic[i]) {
return 2;
--
2.29.2
--000000000000ff70e805b602aa0b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Turns out this doesn't report an er=
ror on PNGSuite xs4n0g01 (signature byte 4 lowercase), and I traced the pro=
blem to here a single comparison in check_magic. --- =C2=A0pngchec=
k.c | 2 +- =C2=A01 file changed, 1 insertion(+), 1 d=
eletion(-)
diff --git a/=
pngcheck.c b/pngcheck.c index 2574ffe..486bacf 10064=
4 --- a/pngcheck.c +++ b/pngc=
heck.c -at--at- -4868,7 +4868,7 -at--at- int check_magic(uch *ma=
gic, char *fname, int which) =C2=A0 =C2=A0const uch =
*good_magic =3D (which =3D=3D 0)? good_PNG_magic : =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0((which =3D=3D 1)? good_MNG_magic : good_JNG_magic)=
; =C2=A0 -=C2=A0 for (i =3D 1=
; i < 3; ++i) +=C2=A0 for (i =3D 1; i <=3D 3; =
++i) =C2=A0 =C2=A0{ =C2=A0 =
=C2=A0 =C2=A0if (magic[i] !=3D good_magic[i]) { =C2=
=A0 =C2=A0 =C2=A0 =C2=A0return 2; --=C2=A0 dir=3D"auto">2.29.2
--000000000000ff70e805b602aa0b--
--===============5421372819667012295==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--===============5421372819667012295==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
png-mng-implement mailing list
png-mng-implement-at-lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-mng-implement
--===============5421372819667012295==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Hangout mailing list
Hangout-at-nylxs.com
http://lists.mrbrklyn.com/mailman/listinfo/hangout
--===============5421372819667012295==--
--===============5421372819667012295==
Content-Type: multipart/alternative; boundary="000000000000ff70e805b602aa0b"
--000000000000ff70e805b602aa0b
Content-Type: text/plain; charset="UTF-8"
Turns out this doesn't report an error on PNGSuite xs4n0g01 (signature byte
4 lowercase), and I traced the problem to here a single comparison in
check_magic.
I originally submitted this to https://github.com/jbowler/pngcheck/pull/2
on the 30th of June 2019, and am finally submitting it upstream now, after
noticing the 2.4.0 release
---
pngcheck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pngcheck.c b/pngcheck.c
index 2574ffe..486bacf 100644
--- a/pngcheck.c
+++ b/pngcheck.c
-at--at- -4868,7 +4868,7 -at--at- int check_magic(uch *magic, char *fname, int which)
const uch *good_magic = (which == 0)? good_PNG_magic :
((which == 1)? good_MNG_magic : good_JNG_magic);
- for (i = 1; i < 3; ++i)
+ for (i = 1; i <= 3; ++i)
{
if (magic[i] != good_magic[i]) {
return 2;
--
2.29.2
--000000000000ff70e805b602aa0b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Turns out this doesn't report an er=
ror on PNGSuite xs4n0g01 (signature byte 4 lowercase), and I traced the pro=
blem to here a single comparison in check_magic. --- =C2=A0pngchec=
k.c | 2 +- =C2=A01 file changed, 1 insertion(+), 1 d=
eletion(-)
diff --git a/=
pngcheck.c b/pngcheck.c index 2574ffe..486bacf 10064=
4 --- a/pngcheck.c +++ b/pngc=
heck.c -at--at- -4868,7 +4868,7 -at--at- int check_magic(uch *ma=
gic, char *fname, int which) =C2=A0 =C2=A0const uch =
*good_magic =3D (which =3D=3D 0)? good_PNG_magic : =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0((which =3D=3D 1)? good_MNG_magic : good_JNG_magic)=
; =C2=A0 -=C2=A0 for (i =3D 1=
; i < 3; ++i) +=C2=A0 for (i =3D 1; i <=3D 3; =
++i) =C2=A0 =C2=A0{ =C2=A0 =
=C2=A0 =C2=A0if (magic[i] !=3D good_magic[i]) { =C2=
=A0 =C2=A0 =C2=A0 =C2=A0return 2; --=C2=A0 dir=3D"auto">2.29.2
--000000000000ff70e805b602aa0b--
--===============5421372819667012295==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--===============5421372819667012295==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
png-mng-implement mailing list
png-mng-implement-at-lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-mng-implement
--===============5421372819667012295==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Hangout mailing list
Hangout-at-nylxs.com
http://lists.mrbrklyn.com/mailman/listinfo/hangout
--===============5421372819667012295==--
|
|
