MESSAGE
| DATE | 2020-12-09 |
| FROM | Lucy Phipps
|
| SUBJECT | Re: [Hangout - NYLXS] [png-mng-implement] [PATCH] pngcheck: check
|
From hangout-bounces-at-nylxs.com Wed Dec 9 11:10:58 2020
Return-Path:
X-Original-To: archive-at-mrbrklyn.com
Delivered-To: archive-at-mrbrklyn.com
Received: from www2.mrbrklyn.com (www2.mrbrklyn.com [96.57.23.82])
by mrbrklyn.com (Postfix) with ESMTP id 126B5163FBB;
Wed, 9 Dec 2020 11:10:58 -0500 (EST)
X-Original-To: hangout-at-www2.mrbrklyn.com
Delivered-To: hangout-at-www2.mrbrklyn.com
Received: by mrbrklyn.com (Postfix, from userid 1000)
id 2621C163F5E; Wed, 9 Dec 2020 11:10:51 -0500 (EST)
Resent-From: Ruben Safir
Resent-Date: Wed, 9 Dec 2020 11:10:51 -0500
Resent-Message-ID: <20201209161051.GB23591-at-www2.mrbrklyn.com>
Resent-To: hangout-at-mrbrklyn.com
X-Original-To: ruben-at-mrbrklyn.com
Delivered-To: ruben-at-mrbrklyn.com
Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7])
by mrbrklyn.com (Postfix) with ESMTP id 6FA79163F5D
for ; Wed, 9 Dec 2020 02:12:38 -0500 (EST)
Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com)
by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1)
(envelope-from )
id 1kmtdv-0001JK-Ke; Wed, 09 Dec 2020 07:12:07 +0000
Received: from [172.30.20.202] (helo=mx.sourceforge.net)
by sfs-ml-1.v29.lw.sourceforge.com with esmtps
(TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1)
(envelope-from ) id 1kmtdt-0001Iv-5G
for png-mng-implement-at-lists.sourceforge.net; Wed, 09 Dec 2020 07:12:05 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Type:To:Subject:Message-ID:Date:From:
In-Reply-To:References:MIME-Version:Sender:Reply-To:Cc:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=1jqoPJLEkfpCU3s6tazUsrtq8PW6JTCMFXtroj5XqyY=; b=Q7HEtohLbiM+MNY3HVtlAEezR
FlIMU2dBjLfGzKGlXrvmbHNDuz9GYwfBqWrOqcKEAWBmTkExr90eq5V6TdBUNvvj76ymcV1cvXuxQ
WxYeF8cZrJGiIkS2irFYx+ra6IftIkR3/KYBwDXdoTsAlLA88k8+BZDNMCkvS+oPAyYEI=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To:References:
MIME-Version:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=1jqoPJLEkfpCU3s6tazUsrtq8PW6JTCMFXtroj5XqyY=; b=lrLrl/nmP868yVMLi2cMUDqnnz
rjGO/ngL/gPHj7c6kQEwT6xz+Notnd5t7XuVwfxl8+cTTQ4nW4BwZ3fL1c2JvdsvCWxGq5x2uLd5e
89dnSW7HtlQuP401tS3LmFTQOmjkZ/af5Hgt807lAl2ai4QOKkHz9s5bqgL1MypBVu6s=;
Received: from mail-yb1-f194.google.com ([209.85.219.194])
by sfi-mx-3.v28.lw.sourceforge.com with esmtps
(TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2)
id 1kmtdg-007SWa-Pm
for png-mng-implement-at-lists.sourceforge.net; Wed, 09 Dec 2020 07:12:05 +0000
Received: by mail-yb1-f194.google.com with SMTP id v67so431693ybi.1
for ;
Tue, 08 Dec 2020 23:11:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
bh=1jqoPJLEkfpCU3s6tazUsrtq8PW6JTCMFXtroj5XqyY=;
b=PeWOWzr/oMiN3TXFku4Qml37phT41rDFTKrpzmwZRLh/fTv9mxvdXvtHdBljM2csZD
xOP9nY7ztzN1h1LcYAM7X1a0iHgb6OT5ynKgCr+RSLTLwLUWEHxAGZ1SH1vopKSsdAQ6
xSH+4Ujasu1WXORSF7kl8UcrNN5SxXlUTiIOfn9rIj1jjZKs6GfE8AyT1pIprZjMVCm3
xfUv/ejdDY1X+rEax+UQQZaD/xx3l4oRIROJZ0mPtfJllSiVXGRkWzWtUtpC2EYgv/Vh
Q0KHAkcH98e7U7PckD71+DJICyRFfg8e4dCJ3LMEQHg+ReaTbUxcRoJN4AMDz6RvUh2b
LM1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to;
bh=1jqoPJLEkfpCU3s6tazUsrtq8PW6JTCMFXtroj5XqyY=;
b=Rx9IgIktVv/QrI7umquXu/fg9r4bMgrU/De4pQvqt6tFZh96Fpse7GvzaAOPsoWxPE
uoMOt0Y1qmGJolNuY9XlDhhe927OP4zJ+FZ2KlZqWvA+JATDTNo2sRK567hK3rQRktaU
5kK372jEM41ri5WLNhgSI4CvsGo0Fs90jd0AiipOu2JnF/x5Elwxpd0LsuWa5HUgD9NL
6jXntAnu7KwATDlZSxHFX/20RfCrnX4FGfMKMfE6Uo9kcm5ZpZTpT1uMmxfoQt18XEGk
IgnE5GpDQu4Ae9yCJGpiEvYiXdo5ShTO1kt0wvR8RUXlkOZ3arrfbMMONzgreH6+y0bn
0OvQ==
X-Gm-Message-State: AOAM532Pk4/WxjNJu0xBZ3uZeZqcV/RqpZ6W7jfnnc5Omq2E3dJGTv/g
k5R0OVuQ+hCfk5YK3Sz6XMJGBOcZgzjigzk2qfAtmhSc
X-Google-Smtp-Source: ABdhPJwavXmRMauhWCfXGXQxGbm7ETbAn52dpdnL6fWa6ZdQCxYDAd2Zhd0Rrq+Z47nq5+Fw4lubYrmTr8S4CjkkMgY=
X-Received: by 2002:a25:3b17:: with SMTP id i23mr1643916yba.240.1607497906936;
Tue, 08 Dec 2020 23:11:46 -0800 (PST)
MIME-Version: 1.0
References:
In-Reply-To:
From: Lucy Phipps
Date: Wed, 9 Dec 2020 07:11:40 +0000
Message-ID:
To: png-mng-implement-at-lists.sourceforge.net
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
See http://spamassassin.org/tag/ for more details.
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(landfillbaby69[at]gmail.com)
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.219.194 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no
trust [209.85.219.194 listed in list.dnswl.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in
digit (landfillbaby69[at]gmail.com)
1.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
X-Headers-End: 1kmtdg-007SWa-Pm
X-BeenThere: png-mng-implement-at-lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
Content-Type: multipart/mixed; boundary="===============5179001979229681258=="
Subject: Re: [Hangout - NYLXS] [png-mng-implement] [PATCH] pngcheck: check
4th byte of header
X-BeenThere: hangout-at-nylxs.com
List-Id: NYLXS Tech Talk and Politics
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Reply-To: PNG/MNG implementation discussion list
Errors-To: hangout-bounces-at-nylxs.com
Sender: "Hangout"
--===============5179001979229681258==
Content-Type: multipart/alternative; boundary="000000000000b85f6205b602c579"
--000000000000b85f6205b602c579
Content-Type: text/plain; charset="UTF-8"
During the long period between pngcheck 2.3.0 and 2.4.0, a fork was set up
at https://github.com/jbowler/pngcheck.
I made a single contribution in June (not July, oops) of 2019, which I just
sent here in my previous email. I'm also waiting for explicit permission
from John Bowler, and Lemures Lemniscati, the only other contributor to the
fork, to submit their work here as well.
On Wed, 9 Dec 2020, 07:04 Lucy Phipps, wrote:
> Turns out this doesn't report an error on PNGSuite xs4n0g01 (signature
> byte 4 lowercase), and I traced the problem to here a single comparison in
> check_magic.
> I originally submitted this to https://github.com/jbowler/pngcheck/pull/2
> on the 30th of June 2019, and am finally submitting it upstream now, after
> noticing the 2.4.0 release
> ---
> pngcheck.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pngcheck.c b/pngcheck.c
> index 2574ffe..486bacf 100644
> --- a/pngcheck.c
> +++ b/pngcheck.c
> -at--at- -4868,7 +4868,7 -at--at- int check_magic(uch *magic, char *fname, int which)
> const uch *good_magic = (which == 0)? good_PNG_magic :
> ((which == 1)? good_MNG_magic : good_JNG_magic);
>
> - for (i = 1; i < 3; ++i)
> + for (i = 1; i <= 3; ++i)
> {
> if (magic[i] != good_magic[i]) {
> return 2;
> --
> 2.29.2
>
>
--000000000000b85f6205b602c579
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
During the long period between pngcheck 2.3.0 and 2.4.0, = a fork was set up at https:=
//github.com/jbowler/pngcheck. I mad=
e a single contribution in June (not July, oops) of 2019, which I just sent=
here in my previous email. I'm also waiting for explicit permission fr=
om John Bowler, and Lemures Lemniscati, the only other contributor to the f=
ork, to submit their work here as well.
gmail_quote"> <= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex"> Turns out=
this doesn't report an error on PNGSuite xs4n0g01 (signature byte 4 lo=
wercase), and I traced the problem to here a single comparison in check_mag=
ic. --- =C2=A0pngc=
heck.c | 2 +- =C2=A01 file changed, 1 insertion(+), =
1 deletion(-)
diff --git=
a/pngcheck.c b/pngcheck.c index 2574ffe..486bacf 10=
0644 --- a/pngcheck.c +++ b/p=
ngcheck.c -at--at- -4868,7 +4868,7 -at--at- int check_magic(uch =
*magic, char *fname, int which) =C2=A0 =C2=A0const u=
ch *good_magic =3D (which =3D=3D 0)? good_PNG_magic : ">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0((which =3D=3D 1)? good_MNG_magic : good_JNG_magic)=
; =C2=A0 -=C2=A0 for (i =3D 1=
; i < 3; ++i) +=C2=A0 for (i =3D 1; i <=3D 3; =
++i) =C2=A0 =C2=A0{ =C2=A0 =
=C2=A0 =C2=A0if (magic[i] !=3D good_magic[i]) { =C2=
=A0 =C2=A0 =C2=A0 =C2=A0return 2; --=C2=A0 dir=3D"auto">2.29.2
--000000000000b85f6205b602c579--
--===============5179001979229681258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--===============5179001979229681258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
png-mng-implement mailing list
png-mng-implement-at-lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-mng-implement
--===============5179001979229681258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Hangout mailing list
Hangout-at-nylxs.com
http://lists.mrbrklyn.com/mailman/listinfo/hangout
--===============5179001979229681258==--
--===============5179001979229681258==
Content-Type: multipart/alternative; boundary="000000000000b85f6205b602c579"
--000000000000b85f6205b602c579
Content-Type: text/plain; charset="UTF-8"
During the long period between pngcheck 2.3.0 and 2.4.0, a fork was set up
at https://github.com/jbowler/pngcheck.
I made a single contribution in June (not July, oops) of 2019, which I just
sent here in my previous email. I'm also waiting for explicit permission
from John Bowler, and Lemures Lemniscati, the only other contributor to the
fork, to submit their work here as well.
On Wed, 9 Dec 2020, 07:04 Lucy Phipps, wrote:
> Turns out this doesn't report an error on PNGSuite xs4n0g01 (signature
> byte 4 lowercase), and I traced the problem to here a single comparison in
> check_magic.
> I originally submitted this to https://github.com/jbowler/pngcheck/pull/2
> on the 30th of June 2019, and am finally submitting it upstream now, after
> noticing the 2.4.0 release
> ---
> pngcheck.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pngcheck.c b/pngcheck.c
> index 2574ffe..486bacf 100644
> --- a/pngcheck.c
> +++ b/pngcheck.c
> -at--at- -4868,7 +4868,7 -at--at- int check_magic(uch *magic, char *fname, int which)
> const uch *good_magic = (which == 0)? good_PNG_magic :
> ((which == 1)? good_MNG_magic : good_JNG_magic);
>
> - for (i = 1; i < 3; ++i)
> + for (i = 1; i <= 3; ++i)
> {
> if (magic[i] != good_magic[i]) {
> return 2;
> --
> 2.29.2
>
>
--000000000000b85f6205b602c579
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
During the long period between pngcheck 2.3.0 and 2.4.0, = a fork was set up at https:=
//github.com/jbowler/pngcheck. I mad=
e a single contribution in June (not July, oops) of 2019, which I just sent=
here in my previous email. I'm also waiting for explicit permission fr=
om John Bowler, and Lemures Lemniscati, the only other contributor to the f=
ork, to submit their work here as well.
gmail_quote"> <= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex"> Turns out=
this doesn't report an error on PNGSuite xs4n0g01 (signature byte 4 lo=
wercase), and I traced the problem to here a single comparison in check_mag=
ic. --- =C2=A0pngc=
heck.c | 2 +- =C2=A01 file changed, 1 insertion(+), =
1 deletion(-)
diff --git=
a/pngcheck.c b/pngcheck.c index 2574ffe..486bacf 10=
0644 --- a/pngcheck.c +++ b/p=
ngcheck.c -at--at- -4868,7 +4868,7 -at--at- int check_magic(uch =
*magic, char *fname, int which) =C2=A0 =C2=A0const u=
ch *good_magic =3D (which =3D=3D 0)? good_PNG_magic : ">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0((which =3D=3D 1)? good_MNG_magic : good_JNG_magic)=
; =C2=A0 -=C2=A0 for (i =3D 1=
; i < 3; ++i) +=C2=A0 for (i =3D 1; i <=3D 3; =
++i) =C2=A0 =C2=A0{ =C2=A0 =
=C2=A0 =C2=A0if (magic[i] !=3D good_magic[i]) { =C2=
=A0 =C2=A0 =C2=A0 =C2=A0return 2; --=C2=A0 dir=3D"auto">2.29.2
--000000000000b85f6205b602c579--
--===============5179001979229681258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--===============5179001979229681258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
png-mng-implement mailing list
png-mng-implement-at-lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/png-mng-implement
--===============5179001979229681258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Hangout mailing list
Hangout-at-nylxs.com
http://lists.mrbrklyn.com/mailman/listinfo/hangout
--===============5179001979229681258==--
|
|
