MESSAGE
| DATE | 2004-04-21 |
| FROM | Billy
|
| SUBJECT | Re: [hangout] Debugging cdparanoia in C
|
On Wed, Apr 21, 2004 at 02:56:17AM -0400, Ruben Safir Secretary NYLXS wrote:
> >
> > Also bothersome is the use of magic numbers 48 and 97
> > instead of '0' and 'a'. Come on!!
>
> That was the line which was origianlly driving me nuts. And of course, this
> is largely a readbility issue.
Absolutely, it's pretty shitty code.
Is this an abandoned project or what? I saw your lonely posts
on the paranoia-dev list.
> I had to right a perl subroutine to print out
> all the ascii characters for me to figure out what they are doing
> (incidently the comment to try 8 at a time is misleading since it is
> trying 4 devices at a time.
it's actually trying 4 letters and 4 numbers per '?' pattern.
So it really is 8, but its still commented badly.
> For what it's worth, man ascii gives a chart, but it cuts shout at decimal 65
> or so. It's a broken man page.
No, it's two columns! There's 0-63, and then there's 64-127 in column 2.
I'm submitting a bug report for this paranoia thing (with a patch) to Debian...
____________________________
NYLXS: New Yorker Free Software Users Scene
Fair Use -
because it's either fair use or useless....
NYLXS is a trademark of NYLXS, Inc
|
|
